From ccf24b3510531ed3b40b7b84f5e09da80a1cdabc Mon Sep 17 00:00:00 2001
From: Pino Toscano <toscano.pino@tiscali.it>
Date: Sat, 5 Jun 2021 11:44:33 +0200
Subject: [PATCH] Switch to PyXDG.IconTheme for icons lookup

Use PyXDG.IconTheme to lookup the application icons instead of pyGTK;
this has some advantages:
- we are already using PyXDG, so it does not add new requirements
- the icon lookup follows the icon theme specs a little bit closer
- the icon lookup does not require an X/graphical session
- there is no implicit 'adwaita' or 'gnome' icon theme used in lookup
there are also few disadvantages:
- there is no concept of "default icon theme", so "hicolor" is hardcoded
  for now; note that, when using pyGTK, the "default icon theme" was the
  GTK one, not any other configured in other ways
- it seems the lookup logic for hicolor returns the smallest icon
  available in case the current size is not available: for example a
  16px PNG is returned instead of a 48px for a requested and not found
  64px size
---
 src/xdgmenumaker | 47 ++++++++++++++++++-----------------------------
 1 file changed, 18 insertions(+), 29 deletions(-)

diff --git a/src/xdgmenumaker b/src/xdgmenumaker
index 05b2a7d..869915e 100755
--- a/src/xdgmenumaker
+++ b/src/xdgmenumaker
@@ -9,6 +9,7 @@ import fnmatch
 import xdg.DesktopEntry as dentry
 import xdg.Exceptions as exc
 import xdg.BaseDirectory as bd
+import xdg.IconTheme as it
 from operator import attrgetter
 
 import configparser as cp
@@ -289,37 +290,25 @@ def icon_max_size(icon):
 
 
 def icon_full_path(icon):
-    # If the icon path is absolute and exists, leave it alone.
-    # This takes care of software that has its own icons stored
-    # in non-standard directories.
-    ext = os.path.splitext(icon)[1].lower()
-    if os.path.exists(icon):
-        if ext == ".svg" or ext == ".svgz":
-            # only jwm supports svg icons
-            if desktop == "jwm" and not nosvg:
-                return icon
-        else:
-            # icon is not svg
-            if max_icon_size:
-                return icon_max_size(icon)
-            else:
-                return icon
-    # fall back to looking for the icon elsewhere in the system
-    icon = icon_strip(icon)
-    icon_theme = gtk.icon_theme_get_default()
-    try:
-        # JWM supports svg icons
-        if desktop == "jwm" and not nosvg:
-            icon = icon_theme.lookup_icon(icon, iconsize, gtk.ICON_LOOKUP_FORCE_SVG)
-        # but none of the other WMs does
-        else:
-            icon = icon_theme.lookup_icon(icon, iconsize, gtk.ICON_LOOKUP_NO_SVG)
-    except AttributeError:
-        sys.exit('ERROR: You need to run xdgmenumaker inside an X session.')
+    args = {
+        'size': iconsize,
+        'theme': 'hicolor'
+    }
+    lookup_svg = True
+    if not desktop == "jwm" or nosvg:
+        lookup_svg = False
+    if not lookup_svg:
+        args['extensions'] = ["png", "xpm"]
+    icon = it.getIconPath(icon, **args)
     if icon:
-        icon = icon.get_filename()
+        ext = os.path.splitext(icon)[1]
+        is_svg = ext == ".svg" or ext == ".svgz"
+        # SVG returned but not requested, most probably is an absolute path:
+        # ignore it, as it is not usable
+        if is_svg and not lookup_svg:
+            icon = None
         # icon size only matters for non-SVG icons
-        if icon and max_icon_size and (ext != ".svg" or ext != ".svgz"):
+        elif max_icon_size and not is_svg:
             icon = icon_max_size(icon)
     return icon